Fix custom image for annotation #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2018 10:37
1ec5
approved these changes
Mar 23, 2018
| - returns: Optionally, a `MGLAnnotationImage` that defines the image used for the annotation. | ||
| */ | ||
| @objc(navigationMapView:imageForAnnotation:) | ||
| optional func navigationMapView(_ mapView: MGLMapView, imageFor annotation: MGLAnnotation) -> MGLAnnotationImage? |
There was a problem hiding this comment.
FYI, this implements part of #685 but takes us further away from being able to allow the developer to just use any MGLMapViewDelegate method, as suggested in #685 (comment).
There was a problem hiding this comment.
Yeah I agree, however lets make the breaking change for all methods in a single pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mapbox/mapbox-navigation-ios-examples#16 (comment)
Unsure how this regressed.
/cc @mapbox/navigation-ios @maxhawkins